MLE-24871: Update Library Versions for Operator 1.1 Release #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 27, 2025 11:48
…iner requests the NET_RAW capability
…d to run as the root user
pengzhouml
requested review from
barkhachoithani,
sumanthravipati and
vitalykorolev
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MarkLogic Operator for the 1.1 release by upgrading Go to 1.24.9, updating Kubernetes client libraries to v0.34.1, controller-runtime to v0.22.3, and various other dependencies. It also addresses security vulnerabilities by adding runAsNonRoot: true to security contexts and includes code quality improvements such as removing unnecessary type conversions, simplifying variable declarations, handling ignored errors, and adding deprecation markers for unused functions.
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates Go version and upgrades Kubernetes and controller-runtime dependencies |
| pkg/k8sutil/statefulset.go | Adds SecretName fallback logic with conditional assignment |
| pkg/k8sutil/service.go | Simplifies variable declarations by removing redundant type specifications |
| pkg/k8sutil/networkPolicy.go | Simplifies variable declaration and adds deprecation comment for unused function |
| pkg/k8sutil/marklogicServer.go | Handles previously ignored return values from result.Done() |
| pkg/k8sutil/ingress.go | Replaces loop-based append with variadic append and adds deprecation comment |
| pkg/k8sutil/haProxyHelper.go | Removes unnecessary int() type conversions and simplifies boolean comparison |
| pkg/k8sutil/haProxy.go | Adds error handling for patch calculation |
| internal/controller/*.go | Reorders imports to place standard library before third-party imports |
| config/manager/*.yaml | Adds runAsNonRoot: true security context setting |
| config/crd/bases/*.yaml | Updates CRD files with new controller-gen version and API documentation changes |
| charts/*.yaml | Updates version to 1.1.0 and adds security contexts |
| test/e2e/*.go | Removes unnecessary string() conversions and simplifies fmt.Sprintf usage |
| Makefile | Updates version to 1.1.0, Kubernetes version, and tooling versions |
| Dockerfile | Updates Go base image to 1.24.9 |
| .golangci.yml | Updates linter configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rwinieski
approved these changes
Oct 28, 2025
vitalykorolev
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include the fix for MLE-24842: Security vulnerabilities in Operator